Add new condition for organizer reminder #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renintw
force-pushed
the
add-new-condition-for-ogreminder
branch
from
430ded6
to
2762c30
Compare
pkevan
reviewed
May 31, 2024
| update_post_meta( $post->ID, 'wcor_send_when', $new_meta['wcor_send_when'] ); | ||
| } | ||
| } | ||
|
|
||
| delete_post_meta( $post->ID, 'wcor_transparency_report' ); | ||
| if ( isset( $new_meta['wcor_transparency_report'] ) ) { | ||
| update_post_meta( $post->ID, 'wcor_transparency_report', $new_meta['wcor_transparency_report'] ); |
There was a problem hiding this comment.
lets make sure to have some sanitization around this since it's just saving from $_POST
renintw
force-pushed
the
add-new-condition-for-ogreminder
branch
from
296890e
to
cd7999e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1327
Description
In this PR, the checkbox
For transparency report - triggered when NOT 'Running money through WPCS PBC'is added. As long as this option is checked, the reminder will determine whether the current WordCamp is running money through WPCS PBC. If not, it will send the email according to the time set below.Testing Cases
For transparency report - triggered when NOT 'Running money through WPCS PBC'is CHECKED-30 days:
7 days:
14 days:
For transparency report - triggered when NOT 'Running money through WPCS PBC'is first CHECKEDThe test here is to ensure that if
For transparency report - triggered when NOT 'Running money through WPCS PBCis not checked, then this reminder email should be sent regardless of whether "Running money through WPCS PBC" is checked or not.Then NOT CHECKED
How to test the changes in this Pull Request:
Same as #1290 (comment)